Skip to content

ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly#68

Merged
rlerdorf merged 4 commits intophp:masterfrom
mrngm:patch-3
Apr 4, 2026
Merged

ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly#68
rlerdorf merged 4 commits intophp:masterfrom
mrngm:patch-3

Conversation

@mrngm
Copy link
Copy Markdown
Contributor

@mrngm mrngm commented May 8, 2023

This prevents compile-time warnings about missing field initializers.

@mrngm mrngm changed the title ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly WIP: ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly May 8, 2023
@langemeijer
Copy link
Copy Markdown
Collaborator

Is this still WIP?

mrngm and others added 2 commits August 1, 2023 16:45
And include comments to refer to PHP's `main/php_streams.h` struct `php_stream_wrapper_ops`.
@mrngm mrngm changed the title WIP: ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly ssh2_fopen_wrappers: initialize php_stream_wrapper_ops explicitly Aug 1, 2023
@mrngm
Copy link
Copy Markdown
Contributor Author

mrngm commented Aug 1, 2023

Apologies for not looking into this for a while. It still needed modifications in ssh2_sftp.c, which I've added just now. I've used the Github interface for updating this branch to the latest master commit, but if you rather have it rebased, let me know.

@rlerdorf rlerdorf merged commit 8d9b6b4 into php:master Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants